Add internalClusterTest to check task #53444
Conversation
This commit adds internalClusterTest in xpack core to run as part of check. This was accidentally removed in a refactoring. Other xpack modules already do this, but core was left out. This commit also mutes 2 tests that currently fail. closes elastic#53407
rjernst
added
>bug
:Delivery/Build
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
| @@ -53,6 +54,7 @@ | |||
| import static org.elasticsearch.test.hamcrest.ElasticsearchAssertions.assertHitCount; | |||
|
|
|||
| @ESIntegTestCase.ClusterScope(numDataNodes = 0) | |||
| @LuceneTestCase.AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/53442") | |||
There was a problem hiding this comment.
this test has been fixed. The AwaitsFix can be removed here
There was a problem hiding this comment.
LGTM
Although I'm wondering if we should do something more generic like check.dependsOn tasks.withType(Test) in BuildPlugin. We'd have to make some exceptions for things like packaging tests and BWC. Perhaps somethign in the testing conventions plugin to freak out if there's a Test task that no other task depends on? That might be difficult to do though in a way that doesn't completely destroy lazy task configuration.
|
I agree we should look at other ways to make this more robust, but I think that is beyond the scope of this PR, which is simply to re-enable these tests as they are now. Let's follow up within the build area to see how we can better model these tests in gradle. |
This commit adds internalClusterTest in xpack core to run as part of check. This was accidentally removed in a refactoring. Other xpack modules already do this, but core was left out. This commit also mutes 2 tests that currently fail. closes #53407
This commit adds internalClusterTest in xpack core to run as part of check. This was accidentally removed in a refactoring. Other xpack modules already do this, but core was left out. This commit also mutes 2 tests that currently fail. closes #53407
This commit adds internalClusterTest in xpack core to run as part of
check. This was accidentally removed in a refactoring. Other xpack
modules already do this, but core was left out. This commit also mutes 2
tests that currently fail.
closes #53407